front: Intervals dataviz - fix issue on point value when zooming #5754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just added the viewbox start value to the point position on the `onMouseMove` of the container (Items already handle it). Moreover, I saw that the hovered point can be negative (due to some margins on HTML elements), so I also added some checks for that
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5754 +/- ##
============================================
- Coverage 19.45% 19.45% -0.01%
Complexity 2327 2327
============================================
Files 907 907
Lines 106925 106927 +2
Branches 2579 2579
============================================
Hits 20801 20801
- Misses 84609 84611 +2
Partials 1515 1515
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5710
I just added the viewbox start value to the point position on the
onMouseMoveof the container (Items already handle it).Moreover, I saw that the hovered point can be negative (due to some margins on HTML elements), so I also added some checks for that