Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: fix mock auth with require_login = false #5756

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

multun
Copy link
Contributor

@multun multun commented Nov 20, 2023

No description provided.

@multun multun requested a review from a team as a code owner November 20, 2023 14:05
Copy link
Member

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (61a0ebd) 19.45% compared to head (f29f465) 19.45%.
Report is 5 commits behind head on dev.

Files Patch % Lines
gateway/actix_auth/src/providers/mock.rs 0.00% 11 Missing ⚠️
gateway/src/config_parser.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5756      +/-   ##
============================================
- Coverage     19.45%   19.45%   -0.01%     
  Complexity     2327     2327              
============================================
  Files           907      907              
  Lines        106925   106935      +10     
  Branches       2579     2579              
============================================
  Hits          20801    20801              
- Misses        84609    84619      +10     
  Partials       1515     1515              
Flag Coverage Δ
gateway 2.55% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multun multun added this pull request to the merge queue Nov 20, 2023
Merged via the queue into dev with commit 34a7092 Nov 20, 2023
@multun multun deleted the gateway-fix-no-login branch November 20, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants