Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: forbid empty study's status #5770

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

woshilapin
Copy link
Contributor

fixes #5714

fix-5674.mov

@woshilapin woshilapin requested a review from a team as a code owner November 21, 2023 12:30
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (4480e1c) 19.68% compared to head (b4b2de6) 19.68%.
Report is 3 commits behind head on dev.

Files Patch % Lines
front/src/modules/study/utils.ts 0.00% 4 Missing ⚠️
...c/modules/study/components/AddOrEditStudyModal.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #5770   +/-   ##
=========================================
  Coverage     19.68%   19.68%           
  Complexity     2332     2332           
=========================================
  Files           910      910           
  Lines        108044   108042    -2     
  Branches       2627     2627           
=========================================
  Hits          21270    21270           
+ Misses        85214    85212    -2     
  Partials       1560     1560           
Flag Coverage Δ
editoast 68.89% <ø> (-0.02%) ⬇️
front 8.63% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woshilapin
Copy link
Contributor Author

I'd take any input about how to test that fix.

@woshilapin woshilapin force-pushed the wsl/fix/5714-no-none-status branch 2 times, most recently from 8e04579 to d7cc6e2 Compare November 21, 2023 13:49
@woshilapin woshilapin requested a review from a team as a code owner November 21, 2023 13:49
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested it and reviewed the openAPI change. Didn't check the front-end part though.

@woshilapin woshilapin force-pushed the wsl/fix/5714-no-none-status branch from d7cc6e2 to fc8ab0e Compare November 21, 2023 15:31
@woshilapin woshilapin requested a review from eckter as a code owner November 21, 2023 15:31
@woshilapin woshilapin force-pushed the wsl/fix/5714-no-none-status branch 2 times, most recently from 717a541 to 34a9cd6 Compare November 22, 2023 08:55
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, thanks :) Left 2 comments

@woshilapin woshilapin force-pushed the wsl/fix/5714-no-none-status branch 2 times, most recently from 4212613 to 025e2e8 Compare November 24, 2023 11:18
@woshilapin woshilapin force-pushed the wsl/fix/5714-no-none-status branch from 025e2e8 to b4b2de6 Compare November 24, 2023 13:31
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@woshilapin woshilapin enabled auto-merge November 27, 2023 09:54
@flomonster flomonster disabled auto-merge November 27, 2023 10:28
@flomonster flomonster merged commit 5366039 into dev Nov 27, 2023
@flomonster flomonster deleted the wsl/fix/5714-no-none-status branch November 27, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Study status should never be "None"
3 participants