-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: forbid empty study's status #5770
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5770 +/- ##
=========================================
Coverage 19.68% 19.68%
Complexity 2332 2332
=========================================
Files 910 910
Lines 108044 108042 -2
Branches 2627 2627
=========================================
Hits 21270 21270
+ Misses 85214 85212 -2
Partials 1560 1560
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'd take any input about how to test that fix. |
8e04579
to
d7cc6e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I tested it and reviewed the openAPI change. Didn't check the front-end part though.
d7cc6e2
to
fc8ab0e
Compare
717a541
to
34a9cd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR, thanks :) Left 2 comments
4212613
to
025e2e8
Compare
025e2e8
to
b4b2de6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
fixes #5714
fix-5674.mov