Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: editor - tooltip and loader on map popup while select #5787

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Nov 22, 2023

Close #5591

@sim51 sim51 requested a review from a team as a code owner November 22, 2023 09:38
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (b6b7dcf) 19.53% compared to head (87fbf8c) 19.52%.

Files Patch % Lines
front/src/common/Loader.tsx 29.03% 22 Missing ⚠️
...src/applications/editor/components/EntitySumUp.tsx 0.00% 2 Missing ⚠️
...applications/editor/tools/selection/components.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5787      +/-   ##
============================================
- Coverage     19.53%   19.52%   -0.01%     
  Complexity     2332     2332              
============================================
  Files           907      907              
  Lines        106998   107016      +18     
  Branches       2593     2593              
============================================
- Hits          20901    20897       -4     
- Misses        84571    84593      +22     
  Partials       1526     1526              
Flag Coverage Δ
front 8.41% <26.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested ✅

@clarani clarani enabled auto-merge November 22, 2023 09:48
@clarani clarani added this pull request to the merge queue Nov 22, 2023
Merged via the queue into dev with commit 0e2b8b5 Nov 22, 2023
@clarani clarani deleted the bsi/issue-5591-2 branch November 22, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infra editor usability enhancement: tooltip and loader display
2 participants