Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: remove unused variable #5841

Merged
merged 1 commit into from
Nov 24, 2023
Merged

nix: remove unused variable #5841

merged 1 commit into from
Nov 24, 2023

Conversation

woshilapin
Copy link
Contributor

@woshilapin woshilapin commented Nov 24, 2023

These variable were causing problems since the default values
are incorrect, and yarn start actually use them in priority.

These variable were causing problems since the default values
are incorrect, and `yarn start` actually use them in priority.
@woshilapin woshilapin changed the title nix: fix default variable 'OSRD_BACKEND_URL' nix: remove unused variable Nov 24, 2023
Copy link
Member

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but removing variables in favor of the .env for the front seems better.

@woshilapin woshilapin enabled auto-merge November 24, 2023 09:46
@woshilapin woshilapin added this pull request to the merge queue Nov 24, 2023
Merged via the queue into dev with commit 4480e1c Nov 24, 2023
@woshilapin woshilapin deleted the wsl/fix/nix-env branch November 24, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants