Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix train initial speed when updating a train #5846

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Nov 24, 2023

close #4216

@clarani clarani requested a review from a team as a code owner November 24, 2023 10:51
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (11bf1b7) 19.68% compared to head (c78cbcd) 19.68%.
Report is 4 commits behind head on dev.

Files Patch % Lines
...ainSchedule/helpers/adjustConfWithTrainToModify.ts 0.00% 2 Missing ⚠️
...ainschedule/components/ImportTrainSchedule/Map.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5846      +/-   ##
============================================
- Coverage     19.68%   19.68%   -0.01%     
  Complexity     2332     2332              
============================================
  Files           910      910              
  Lines        108044   108045       +1     
  Branches       2627     2627              
============================================
  Hits          21269    21269              
- Misses        85215    85216       +1     
  Partials       1560     1560              
Flag Coverage Δ
front 8.63% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni-4216-fix-start-speed branch from 6a3e9b1 to bcefcf1 Compare November 24, 2023 11:23
@clarani clarani force-pushed the cni-4216-fix-start-speed branch from bcefcf1 to c78cbcd Compare November 24, 2023 11:23
@clarani clarani enabled auto-merge November 24, 2023 11:26
@clarani clarani added this pull request to the merge queue Nov 27, 2023
Merged via the queue into dev with commit f755dc9 Nov 27, 2023
@clarani clarani deleted the cni-4216-fix-start-speed branch November 27, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: start speed changes when editing a train
5 participants