Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: editor - force reload of EditorSource when data changed #5852

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Nov 24, 2023

Close #5845

@sim51 sim51 requested a review from a team as a code owner November 24, 2023 15:16
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (b6ead5b) 19.70% compared to head (9ddffb3) 19.70%.
Report is 2 commits behind head on dev.

Files Patch % Lines
front/src/common/Map/Layers/GeoJSONs.tsx 0.00% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5852      +/-   ##
============================================
- Coverage     19.70%   19.70%   -0.01%     
  Complexity     2345     2345              
============================================
  Files           910      910              
  Lines        108075   108081       +6     
  Branches       2634     2634              
============================================
  Hits          21299    21299              
- Misses        85216    85222       +6     
  Partials       1560     1560              
Flag Coverage Δ
front 8.63% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in local and it works well. Left one comment

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@clarani clarani added this pull request to the merge queue Nov 27, 2023
Merged via the queue into dev with commit db6b053 Nov 27, 2023
@clarani clarani deleted the bsi/issue-5845 branch November 27, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor : wrong cursor when add an object
3 participants