Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix psl saving #5854

Merged
merged 1 commit into from
Nov 28, 2023
Merged

front: fix psl saving #5854

merged 1 commit into from
Nov 28, 2023

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Nov 24, 2023 •
edited
Loading

close #5792
close #5842

  • Add empty string ("") as default value for value field in psl signs
  • Add KP field for PSL signs forms with empty string ("") as default value
  • Disabled PSL checkbox if no track section is selected and add message helper for the user

@SharglutDev SharglutDev force-pushed the pfn/front/fix-psl-saving branch from 648470c to a30a59c Compare November 24, 2023 15:38
@codecov Codecov
Copy link

codecov bot commented Nov 24, 2023 •
edited
Loading

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (b6ead5b) 19.70% compared to head (a30a59c) 19.70%.
Report is 3 commits behind head on dev.

Files Patch % Lines
...or/tools/rangeEdition/speedSection/PslSignCard.tsx 0.00% 15 Missing ⚠️
...lications/editor/tools/rangeEdition/components.tsx 0.00% 6 Missing ⚠️
...tools/rangeEdition/speedSection/EditPSLSection.tsx 0.00% 3 Missing ⚠️
front/src/types/editor.ts 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #5854      +/-   ##
============================================
- Coverage     19.70%   19.70%   -0.01%     
  Complexity     2345     2345              
============================================
  Files           910      910              
  Lines        108075   108108      +33     
  Branches       2634     2634              
============================================
  Hits          21299    21299              
- Misses        85216    85249      +33     
  Partials       1560     1560
Flag Coverage Δ
front 8.63% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev marked this pull request as ready for review November 28, 2023 11:09
@SharglutDev SharglutDev requested a review from a team as a code owner November 28, 2023 11:09
SarahBellaha
SarahBellaha approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job :)

clarani
clarani approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job ! 💪 ✅

@SharglutDev SharglutDev added this pull request to the merge queue Nov 28, 2023
Merged via the queue into dev with commit 5c1ef6c Nov 28, 2023
@SharglutDev SharglutDev deleted the pfn/front/fix-psl-saving branch November 28, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wadjetz Wadjetz Wadjetz approved these changes

@clarani clarani clarani approved these changes

@SarahBellaha SarahBellaha SarahBellaha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editor : button to create LPV is not activated Cannot save a new PSL
4 participants
@SharglutDev @Wadjetz @clarani @SarahBellaha