-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type and path faster than light #5870
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5870 +/- ##
============================================
- Coverage 19.86% 19.43% -0.43%
- Complexity 2122 2332 +210
============================================
Files 910 909 -1
Lines 108401 108164 -237
Branches 2649 2637 -12
============================================
- Hits 21538 21027 -511
- Misses 85309 85567 +258
- Partials 1554 1570 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
797436a
to
8529f00
Compare
84c0443
to
d40c402
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this great PR ! Left some comments.
Also what's the plan to replace the rocket button for production ? :)
front/src/modules/trainschedule/components/ManageTrainSchedule/Itinerary/DisplayVias.tsx
Show resolved
Hide resolved
.../modules/trainschedule/components/ManageTrainSchedule/helpers/adjustConfWithTrainToModify.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested :) Great job ! (to be continued for the rocket substitute)
ae47086
to
53cacb8
Compare
Click on the rocket !!
Small input field to establish path using trigram. Follow instructions to test, but beware, a lot of paths are actually failing.
You can test with OP from screenshots, or try "PLY MSC", "TE AN", "PLY DN".
Limits:
close #4977