Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type and path faster than light #5870

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

nicolaswurtz
Copy link
Contributor

@nicolaswurtz nicolaswurtz commented Nov 25, 2023

Click on the rocket !!

Small input field to establish path using trigram. Follow instructions to test, but beware, a lot of paths are actually failing.
You can test with OP from screenshots, or try "PLY MSC", "TE AN", "PLY DN".

Limits:

  • pathfinding state in above section is not updated with this path search, sorry, it was way too complicated (need rewriting of whole component)
  • more than 30/40 trigrams is difficult to display, but who needs (and who knows???) so much trigrams at a time ?

image
image

close #4977

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 235 lines in your changes are missing coverage. Please review.

Comparison is base (9667656) 19.86% compared to head (ae47086) 19.43%.

❗ Current head ae47086 differs from pull request most recent head 53cacb8. Consider uploading reports for the commit 53cacb8 to get more accurate results

Files Patch % Lines
front/src/common/Pathfinding/TypeAndPath.tsx 0.00% 179 Missing and 1 partial ⚠️
...ainSchedule/helpers/adjustConfWithTrainToModify.ts 0.00% 21 Missing ⚠️
...onents/ManageTrainSchedule/Itinerary/Itinerary.tsx 0.00% 17 Missing ⚠️
front/src/common/Pathfinding/Pathfinding.tsx 9.09% 10 Missing ⚠️
.../ManageTrainScheduleMap/RenderItineraryMarkers.tsx 0.00% 3 Missing ⚠️
...s/operationalStudies/views/ManageTrainSchedule.tsx 0.00% 2 Missing ⚠️
...rainSchedule/Itinerary/DisplayItinerary/Origin.tsx 0.00% 1 Missing ⚠️
...ents/ManageTrainSchedule/Itinerary/DisplayVias.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5870      +/-   ##
============================================
- Coverage     19.86%   19.43%   -0.43%     
- Complexity     2122     2332     +210     
============================================
  Files           910      909       -1     
  Lines        108401   108164     -237     
  Branches       2649     2637      -12     
============================================
- Hits          21538    21027     -511     
- Misses        85309    85567     +258     
- Partials       1554     1570      +16     
Flag Coverage Δ
front 8.44% <0.42%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolaswurtz nicolaswurtz force-pushed the nwz/type-and-path-faster-than-light branch 2 times, most recently from 797436a to 8529f00 Compare November 25, 2023 01:39
@nicolaswurtz nicolaswurtz marked this pull request as ready for review November 25, 2023 01:45
@nicolaswurtz nicolaswurtz requested a review from a team as a code owner November 25, 2023 01:45
@nicolaswurtz nicolaswurtz force-pushed the nwz/type-and-path-faster-than-light branch 2 times, most recently from 84c0443 to d40c402 Compare November 25, 2023 02:21
@nicolaswurtz nicolaswurtz added kind:enhancement Improvement of existing features area:front Work on Standard OSRD Interface modules labels Nov 25, 2023
@flomonster flomonster changed the title Nwz/type and path faster than light Type and path faster than light Nov 27, 2023
@SharglutDev SharglutDev self-requested a review November 27, 2023 14:04
@SharglutDev SharglutDev self-assigned this Nov 27, 2023
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great PR ! Left some comments.

Also what's the plan to replace the rocket button for production ? :)

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested :) Great job ! (to be continued for the rocket substitute)

@nicolaswurtz nicolaswurtz force-pushed the nwz/type-and-path-faster-than-light branch from ae47086 to 53cacb8 Compare November 28, 2023 17:50
@nicolaswurtz nicolaswurtz added this pull request to the merge queue Nov 28, 2023
Merged via the queue into dev with commit 31f40a6 Nov 28, 2023
@nicolaswurtz nicolaswurtz deleted the nwz/type-and-path-faster-than-light branch November 28, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react warning when adding at least 2 vias with the map module
3 participants