Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: use RollingStockComfortType from OpenApi, not Comfort from legacy #5878

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

Tristramg
Copy link
Contributor

No description provided.

@Tristramg Tristramg requested a review from a team as a code owner November 27, 2023 14:51
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (f5848dd) 19.86% compared to head (e20b3ae) 19.86%.

Files Patch % Lines
...nents/RollingStockSelector/RollingStockHelpers.tsx 0.00% 6 Missing ⚠️
...ules/rollingStock/components/RollingStockCurve.tsx 0.00% 5 Missing ⚠️
...onents/RollingStockCard/RollingStockCardDetail.tsx 0.00% 4 Missing ⚠️
...onents/RollingStockEditor/AddRollingstockParam.tsx 0.00% 4 Missing ⚠️
...ts/RollingStockEditor/RollingStockEditorCurves.tsx 0.00% 4 Missing ⚠️
...k/components/RollingStockCard/RollingStockCard.tsx 0.00% 2 Missing ⚠️
...ollingStockEditor/RollingStockInformationPanel.tsx 0.00% 2 Missing ⚠️
...ents/RollingStockSelector/RollingStockSelector.tsx 0.00% 2 Missing ⚠️
front/src/modules/rollingStock/helpers/utils.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5878      +/-   ##
============================================
- Coverage     19.86%   19.86%   -0.01%     
  Complexity     2122     2122              
============================================
  Files           910      910              
  Lines        108337   108343       +6     
  Branches       2649     2649              
============================================
  Hits          21525    21525              
- Misses        85258    85264       +6     
  Partials       1554     1554              
Flag Coverage Δ
front 8.64% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Tristramg Tristramg added this pull request to the merge queue Nov 29, 2023
Merged via the queue into dev with commit cb3487a Nov 29, 2023
@Tristramg Tristramg deleted the utoipa_comfort branch November 29, 2023 15:15
@Tristramg Tristramg self-assigned this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants