Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search tool in editor #5892

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Add search tool in editor #5892

merged 1 commit into from
Nov 29, 2023

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Nov 28, 2023 •
edited
Loading

closes #5523

  • icon replacement with Go ones

@Akctarus Akctarus requested a review from a team as a code owner November 28, 2023 14:18
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (532a211) 19.86% compared to head (dee4f50) 19.67%.
Report is 15 commits behind head on dev.

Files Patch % Lines
front/src/applications/editor/nav.tsx 0.00% 13 Missing ⚠️
front/src/applications/editor/Editor.tsx 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #5892      +/-   ##
============================================
- Coverage     19.86%   19.67%   -0.20%     
  Complexity     2122     2122              
============================================
  Files           910      910              
  Lines        108338   108547     +209     
  Branches       2649     2659      +10     
============================================
- Hits          21523    21358     -165     
- Misses        85261    85625     +364     
- Partials       1554     1564      +10
Flag Coverage Δ
front 8.43% <0.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Yohh
Yohh approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! LGTM 💪

@flomonster flomonster changed the title front: add search tool in editor map Add search tool in editor map Nov 28, 2023
@flomonster flomonster changed the title Add search tool in editor map Add search tool in editor Nov 28, 2023
nicolaswurtz
nicolaswurtz suggested changes Nov 28, 2023
View reviewed changes
@Akctarus Akctarus force-pushed the tmn/front/add-search-in-editor branch from a92659d to dee4f50 Compare November 29, 2023 10:50
@Akctarus Akctarus added this pull request to the merge queue Nov 29, 2023
Merged via the queue into dev with commit 35c113a Nov 29, 2023
@Akctarus Akctarus deleted the tmn/front/add-search-in-editor branch November 29, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tykayn tykayn tykayn approved these changes

@nicolaswurtz nicolaswurtz nicolaswurtz approved these changes

@Yohh Yohh Yohh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigate using search bar in editors map
5 participants
@Akctarus @tykayn @nicolaswurtz @Yohh @SarahBellaha