Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: handle generic exceptions #5916

Merged
merged 1 commit into from
Nov 29, 2023
Merged

core: handle generic exceptions #5916

merged 1 commit into from
Nov 29, 2023

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Nov 29, 2023

No description provided.

@eckter eckter requested a review from a team as a code owner November 29, 2023 15:15
@eckter eckter requested a review from Erashin November 29, 2023 15:15
@eckter eckter force-pushed the ech/handle-generic-exceptions branch from 825d32c to 781bf26 Compare November 29, 2023 15:18
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (35c113a) 19.68% compared to head (781bf26) 19.68%.
Report is 2 commits behind head on dev.

Files Patch % Lines
...a/fr/sncf/osrd/reporting/exceptions/OSRDError.java 0.00% 5 Missing ⚠️
...c/main/java/fr/sncf/osrd/api/ExceptionHandler.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #5916   +/-   ##
=========================================
  Coverage     19.68%   19.68%           
  Complexity     2118     2118           
=========================================
  Files           910      910           
  Lines        108588   108593    +5     
  Branches       2662     2662           
=========================================
+ Hits          21376    21377    +1     
- Misses        85642    85646    +4     
  Partials       1570     1570           
Flag Coverage Δ
core 78.97% <14.28%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter added this pull request to the merge queue Nov 29, 2023
Merged via the queue into dev with commit 1dcf908 Nov 29, 2023
@eckter eckter deleted the ech/handle-generic-exceptions branch November 29, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants