Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: operationalstudies: fix scenario and study card names wrong display when too long #5961

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Dec 1, 2023

  • add names in span then give it "-text" classname suffix
  • add elipsis to those classnames

close #5937

@Yohh Yohh added area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management labels Dec 1, 2023
@Yohh Yohh requested a review from a team as a code owner December 1, 2023 13:06
@Yohh Yohh force-pushed the yoh/front-fix-scenario-and-study-long-names branch from d53d189 to efe1d08 Compare December 1, 2023 13:07
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (80f4ffc) 25.72% compared to head (e6df8f2) 25.70%.

Files Patch % Lines
...t/src/modules/scenario/components/ScenarioCard.tsx 0.00% 3 Missing ⚠️
front/src/modules/study/components/StudyCard.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5961      +/-   ##
============================================
- Coverage     25.72%   25.70%   -0.02%     
  Complexity     2117     2117              
============================================
  Files           924      924              
  Lines        122308   122312       +4     
  Branches       2662     2662              
============================================
- Hits          31463    31442      -21     
- Misses        89275    89300      +25     
  Partials       1570     1570              
Flag Coverage Δ
core 79.01% <ø> (ø)
editoast 73.45% <ø> (-0.11%) ⬇️
front 8.44% <0.00%> (-0.01%) ⬇️
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Yohh Yohh force-pushed the yoh/front-fix-scenario-and-study-long-names branch from efe1d08 to 9d49d6b Compare December 1, 2023 14:32
…splay when too long

- add names in span then give it "-text" classname suffix
- add elipsis to those classnames
@Yohh Yohh force-pushed the yoh/front-fix-scenario-and-study-long-names branch from 9d49d6b to e6df8f2 Compare December 1, 2023 15:07
@Yohh Yohh added this pull request to the merge queue Dec 1, 2023
Merged via the queue into dev with commit 0ffab66 Dec 1, 2023
@Yohh Yohh deleted the yoh/front-fix-scenario-and-study-long-names branch December 1, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: long text out of the box in study, making buttons unclickable
3 participants