Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: rolling stock editor too many digits fix #5985

Merged
merged 1 commit into from
Dec 8, 2023
Merged

front: rolling stock editor too many digits fix #5985

merged 1 commit into from
Dec 8, 2023

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Dec 4, 2023

close #5587

@Wadjetz Wadjetz added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules module:rollingstocks-editor A module dedicated to rollingstock editors labels Dec 4, 2023
@Wadjetz Wadjetz self-assigned this Dec 4, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (a937195) 26.54% compared to head (1bbc340) 26.55%.

Files Patch % Lines
front/src/common/BootstrapSNCF/InputGroupSNCF.tsx 20.00% 28 Missing ⚠️
front/src/utils/numbers.ts 64.00% 0 Missing and 9 partials ⚠️
...onents/RollingStockCard/RollingStockCardDetail.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                dev    #5985   +/-   ##
=========================================
  Coverage     26.54%   26.55%           
  Complexity     2118     2118           
=========================================
  Files           931      931           
  Lines        122892   122945   +53     
  Branches       2664     2673    +9     
=========================================
+ Hits          32623    32643   +20     
- Misses        88693    88717   +24     
- Partials       1576     1585    +9
Flag Coverage Δ
core 78.94% <ø> (ø)
editoast 74.66% <ø> (-0.01%) ⬇️
front 9.33% <38.09%> (+0.01%) ⬆️
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz marked this pull request as ready for review December 4, 2023 13:20
@Wadjetz Wadjetz requested a review from a team as a code owner December 4, 2023 13:20
@Wadjetz Wadjetz requested a review from clarani December 4, 2023 13:20
@Wadjetz Wadjetz force-pushed the ebe/rolling-stock-editor-too-many-digits-fix branch from e3df53c to b9b31f6 Compare December 4, 2023 16:19
@Wadjetz Wadjetz requested a review from SharglutDev December 5, 2023 12:32
@Wadjetz Wadjetz force-pushed the ebe/rolling-stock-editor-too-many-digits-fix branch from b9b31f6 to 660752d Compare December 5, 2023 14:04
@Wadjetz Wadjetz requested a review from anisometropie December 5, 2023 14:06
@Wadjetz Wadjetz force-pushed the ebe/rolling-stock-editor-too-many-digits-fix branch from 5289722 to 19dc9a4 Compare December 5, 2023 16:17
@Wadjetz Wadjetz requested a review from clarani December 6, 2023 12:54
@Wadjetz Wadjetz force-pushed the ebe/rolling-stock-editor-too-many-digits-fix branch from 19dc9a4 to 45021fe Compare December 6, 2023 13:38
clarani
clarani approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

@Wadjetz Wadjetz force-pushed the ebe/rolling-stock-editor-too-many-digits-fix branch 3 times, most recently from e326b2f to 7f0e2a1 Compare December 7, 2023 14:07
@Wadjetz Wadjetz force-pushed the ebe/rolling-stock-editor-too-many-digits-fix branch from 7f0e2a1 to 98e258f Compare December 7, 2023 15:37
@Wadjetz Wadjetz requested a review from anisometropie December 7, 2023 15:38
@Wadjetz Wadjetz force-pushed the ebe/rolling-stock-editor-too-many-digits-fix branch from 98e258f to 1bbc340 Compare December 8, 2023 14:58
@Wadjetz Wadjetz enabled auto-merge December 8, 2023 14:58
@Wadjetz Wadjetz added this pull request to the merge queue Dec 8, 2023
Merged via the queue into dev with commit 381f900 Dec 8, 2023
@Wadjetz Wadjetz deleted the ebe/rolling-stock-editor-too-many-digits-fix branch December 8, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anisometropie anisometropie anisometropie approved these changes

@clarani clarani clarani approved these changes

@SharglutDev SharglutDev Awaiting requested review from SharglutDev

Assignees

@Wadjetz Wadjetz

Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:rollingstocks-editor A module dedicated to rollingstock editors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too many digits in rolling stock edition mode, not enough in visualization mode
3 participants
@Wadjetz @anisometropie @clarani