Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: order electrical profils #6000

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

SarahBellaha
Copy link
Contributor

@SarahBellaha SarahBellaha commented Dec 5, 2023

Close #5412
Close #5562 (same issue)

@SarahBellaha SarahBellaha requested a review from a team as a code owner December 5, 2023 10:14
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (192be49) 26.50% compared to head (8e28efa) 26.51%.
Report is 1 commits behind head on dev.

Files Patch % Lines
front/src/modules/rollingStock/helpers/utils.ts 53.84% 2 Missing and 4 partials ⚠️
...ts/RollingStockEditor/RollingStockEditorCurves.tsx 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6000      +/-   ##
============================================
+ Coverage     26.50%   26.51%   +0.01%     
  Complexity     2117     2117              
============================================
  Files           930      930              
  Lines        122560   122596      +36     
  Branches       2665     2669       +4     
============================================
+ Hits          32484    32511      +27     
- Misses        88503    88508       +5     
- Partials       1573     1577       +4     
Flag Coverage Δ
core 78.97% <ø> (ø)
editoast 74.52% <ø> (ø)
front 9.33% <74.35%> (+0.02%) ⬆️
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBellaha SarahBellaha force-pushed the sba/front/order-electrical-profils branch from d076c61 to 8aef46c Compare December 5, 2023 10:53
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@SarahBellaha SarahBellaha force-pushed the sba/front/order-electrical-profils branch from 7efe2e7 to 2d31167 Compare December 5, 2023 14:05
Copy link
Contributor

@axrolld axrolld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🎉

@SarahBellaha SarahBellaha force-pushed the sba/front/order-electrical-profils branch from 2d31167 to db4b15b Compare December 5, 2023 14:08
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks ✅ Tested !

@SarahBellaha SarahBellaha force-pushed the sba/front/order-electrical-profils branch from db4b15b to 8e28efa Compare December 6, 2023 10:20
@SarahBellaha SarahBellaha added this pull request to the merge queue Dec 6, 2023
Merged via the queue into dev with commit 1a763d9 Dec 6, 2023
@SarahBellaha SarahBellaha deleted the sba/front/order-electrical-profils branch December 6, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electrical profiles are not always in the right order Electrical profile O is not put in the right order
5 participants