core: fix linestring interpolation #6015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khoyo
requested changes
Dec 5, 2023
multun
force-pushed
the
fix-linestring-interpolation
branch
from
4aa9cd3 to
cd67976
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6015 +/- ##
============================================
- Coverage 26.49% 26.49% -0.01%
Complexity 2117 2117
============================================
Files 930 930
Lines 122661 122683 +22
Branches 2664 2667 +3
============================================
+ Hits 32499 32500 +1
- Misses 88590 88608 +18
- Partials 1572 1575 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
multun
force-pushed
the
fix-linestring-interpolation
branch
from
cd67976 to
1d934cd
Compare
The previous code sometimes failed when two linestring points share the same coordinates. I decided on replacing the previous algorithm by a tried and tested approach instead of working out its kinks.
multun
force-pushed
the
fix-linestring-interpolation
branch
from
1d934cd to
e851720
Compare
Khoyo
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code sometimes failed when two linestring points share the same coordinates. I decided on replacing the previous algorithm by a tried and tested approach instead of working out its kinks.