Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix osm layers render #6039

Merged
merged 1 commit into from
Dec 6, 2023
Merged

front: fix osm layers render #6039

merged 1 commit into from
Dec 6, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Dec 6, 2023

closes #5849

The OSM layers need to be reloaded once the map is loaded (not only when the map style changes).

@clarani clarani requested a review from a team as a code owner December 6, 2023 15:19
@clarani clarani enabled auto-merge December 6, 2023 15:22
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (f3abe90) 26.51% compared to head (76ea95b) 26.51%.
Report is 2 commits behind head on dev.

Files Patch % Lines
...ainschedule/components/ManageTrainSchedule/Map.tsx 0.00% 13 Missing ⚠️
front/src/applications/referenceMap/Map.tsx 0.00% 10 Missing ⚠️
...mulationResult/components/SimulationResultsMap.tsx 0.00% 5 Missing ⚠️
front/src/common/Map/Layers/OSM.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6039      +/-   ##
============================================
- Coverage     26.51%   26.51%   -0.01%     
  Complexity     2117     2117              
============================================
  Files           930      930              
  Lines        122714   122733      +19     
  Branches       2669     2669              
============================================
  Hits          32542    32542              
- Misses        88595    88614      +19     
  Partials       1577     1577              
Flag Coverage Δ
core 78.97% <ø> (ø)
editoast 74.55% <ø> (ø)
front 9.32% <0.00%> (-0.01%) ⬇️
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani added this pull request to the merge queue Dec 6, 2023
Merged via the queue into dev with commit b7a8a8e Dec 6, 2023
@clarani clarani deleted the cni-5849-fix-osm-layers branch December 6, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSM map needs to be retoggled to be displayed
2 participants