Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: modify getScaleDomainFromValues function #6042

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

SarahBellaha
Copy link
Contributor

Takes account of the last comment in this PR #6031

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (fb39845) 26.50% compared to head (1d66055) 26.55%.
Report is 4 commits behind head on dev.

Files Patch % Lines
...lt/components/ChartHelpers/enableInteractivity.tsx 0.00% 3 Missing ⚠️
...ult/components/SpeedSpaceChart/SpeedSpaceChart.tsx 0.00% 3 Missing ⚠️
...omponents/ChartHelpers/getScaleDomainFromValues.ts 0.00% 2 Missing ⚠️
.../simulationResult/components/SpaceCurvesSlopes.tsx 0.00% 2 Missing ⚠️
...ons/operationalStudies/views/SimulationResults.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6042      +/-   ##
============================================
+ Coverage     26.50%   26.55%   +0.05%     
  Complexity     2117     2117              
============================================
  Files           931      931              
  Lines        122820   122902      +82     
  Branches       2670     2670              
============================================
+ Hits          32549    32633      +84     
+ Misses        88693    88691       -2     
  Partials       1578     1578              
Flag Coverage Δ
core 78.97% <ø> (ø)
editoast 74.66% <ø> (+0.10%) ⬆️
front 9.31% <0.00%> (+<0.01%) ⬆️
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, tested

@SarahBellaha SarahBellaha force-pushed the sba/front/fixup-pr-6031 branch from 9b8cf4d to 1d66055 Compare December 7, 2023 10:38
@SarahBellaha SarahBellaha added this pull request to the merge queue Dec 7, 2023
@SarahBellaha SarahBellaha removed this pull request from the merge queue due to a manual request Dec 7, 2023
@SarahBellaha SarahBellaha added this pull request to the merge queue Dec 7, 2023
Merged via the queue into dev with commit 377da22 Dec 7, 2023
@SarahBellaha SarahBellaha deleted the sba/front/fixup-pr-6031 branch December 7, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants