Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: fix release build #6084

Merged
merged 1 commit into from
Dec 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/scripts/bake-metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,15 +207,19 @@ def get_cache_from(self, target: Target) -> List[str]:

@dataclass
class ReleaseEvent(BaseEvent):
release_name: str
tag_name: str
commit_hash: str
draft: bool

def version_string(self):
return f"{self.release_name} {short_hash(self.commit_hash)}"
return f"{self.get_stable_version()} {short_hash(self.commit_hash)}"

def get_stable_version(self) -> str:
# stable/osrd-front:1.0-devel # 1.0 XXXX
return self.release_name
name = self.tag_name
if self.draft:
name = f"{name}-draft"
return name

def get_stable_image_namer(self) -> ImageNamer:
return release_image
Expand Down Expand Up @@ -252,7 +256,12 @@ def parse_event(context) -> Event:
return MergeGroupEvent(commit_hash, target_branch)

if event_name == "release":
return ReleaseEvent(ref, commit_hash)
release = event["release"]
return ReleaseEvent(
release["tag_name"],
commit_hash,
release["draft"],
)

if event_name in ("workflow_dispatch", "push"):
return BranchEvent(ref_name, protected, commit_hash)
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,13 @@ jobs:
GITHUB_CONTEXT: ${{ toJson(github) }}
run: |
set -eo pipefail
echo ::group::Github context
python3 -m json.tool <<< "${GITHUB_CONTEXT}"
echo ::endgroup::

echo ::group::Bake metadata
.github/scripts/bake-metadata.py | tee bake-metadata.json
echo ::endgroup::

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
Expand Down