Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix wrong suggeredvias selection #6125

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Dec 14, 2023

close #6120

  • format the suggeredVias without the duplicates
  • add some margin for the icons to prevent overflow with the scrollbar
  • some refacto for non usefull code

⚠️ This fixes only the related issue. The component is still weird because of this bug

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (3a3bc3f) 26.93% compared to head (e0e04c6) 26.93%.

Files Patch % Lines
...anageTrainSchedule/Itinerary/ModalSuggeredVias.tsx 0.00% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6125      +/-   ##
============================================
- Coverage     26.93%   26.93%   -0.01%     
  Complexity     2136     2136              
============================================
  Files           961      961              
  Lines        124258   124259       +1     
  Branches       2574     2574              
============================================
  Hits          33472    33472              
- Misses        89297    89298       +1     
  Partials       1489     1489              
Flag Coverage Δ
core 78.88% <ø> (ø)
editoast 75.46% <ø> (ø)
front 8.69% <0.00%> (-0.01%) ⬇️
gateway 2.54% <ø> (ø)
tests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/fix-suggeredvias-selection branch 3 times, most recently from 0911235 to 118131b Compare December 15, 2023 15:50
@SharglutDev SharglutDev marked this pull request as ready for review December 15, 2023 15:50
@SharglutDev SharglutDev requested a review from a team as a code owner December 15, 2023 15:50
@SharglutDev SharglutDev force-pushed the pfn/front/fix-suggeredvias-selection branch from 118131b to 7fe0d43 Compare December 21, 2023 07:40
@SharglutDev SharglutDev force-pushed the pfn/front/fix-suggeredvias-selection branch from 7fe0d43 to e0e04c6 Compare January 4, 2024 09:47
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

@SharglutDev SharglutDev added this pull request to the merge queue Jan 4, 2024
Merged via the queue into dev with commit a43f840 Jan 4, 2024
@SharglutDev SharglutDev deleted the pfn/front/fix-suggeredvias-selection branch January 4, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple OP seem to be selected instead of just one in the vias modal window
2 participants