Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: create/update API is now correctly defined in OpenAPI #6144

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

woshilapin
Copy link
Contributor

The edition (create or update) of objects is now broken because the OpenAPI was incorrectly updated in #5924.

The serialized object on editoast is RailjsonObject (something like {"id": "..."}) which ends up being serialized with a wrapper because of #[serde(tag = "obj_type")] (so more like {"obj_type": "Catenary", "railjson": { "id": "...", ... }}).

@woshilapin woshilapin requested review from a team as code owners December 18, 2023 15:07
@woshilapin woshilapin requested a review from Tristramg December 18, 2023 15:07
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, creation and edition of a track is now fixed on my side

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lightly tested locally as well. I have a few eslint warnings on my side (prefer-destructuring). That might be the reason why the ci build fails.

@woshilapin woshilapin force-pushed the wsl/fix/5856-broken-openapi branch from 96e2e90 to b5da242 Compare December 18, 2023 16:15
@woshilapin woshilapin enabled auto-merge December 18, 2023 16:15
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e3b89a8) 26.63% compared to head (0a60fd8) 26.63%.
Report is 1 commits behind head on dev.

Files Patch % Lines
...cations/editor/tools/rangeEdition/tool-factory.tsx 0.00% 2 Missing ⚠️
...ications/editor/tools/switchEdition/components.tsx 0.00% 2 Missing ⚠️
...lications/editor/tools/trackEdition/components.tsx 0.00% 2 Missing ⚠️
...lications/editor/tools/pointEdition/components.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6144      +/-   ##
============================================
- Coverage     26.63%   26.63%   -0.01%     
  Complexity     2123     2123              
============================================
  Files           930      930              
  Lines        123359   123356       -3     
  Branches       2677     2677              
============================================
- Hits          32857    32856       -1     
+ Misses        88916    88914       -2     
  Partials       1586     1586              
Flag Coverage Δ
core 78.97% <ø> (ø)
editoast 74.94% <ø> (ø)
front 9.36% <50.00%> (-0.01%) ⬇️
gateway 2.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woshilapin woshilapin force-pushed the wsl/fix/5856-broken-openapi branch from b5da242 to 9b99b89 Compare December 18, 2023 22:55
@woshilapin woshilapin force-pushed the wsl/fix/5856-broken-openapi branch from 9b99b89 to 0a60fd8 Compare December 19, 2023 07:31
@woshilapin woshilapin added this pull request to the merge queue Dec 19, 2023
Merged via the queue into dev with commit faae221 Dec 19, 2023
@woshilapin woshilapin deleted the wsl/fix/5856-broken-openapi branch December 19, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants