-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: lock infra editor #6173
front: lock infra editor #6173
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6173 +/- ##
============================================
- Coverage 27.90% 27.90% -0.01%
Complexity 2165 2165
============================================
Files 1006 1006
Lines 126848 126877 +29
Branches 2581 2582 +1
============================================
+ Hits 35401 35409 +8
- Misses 89956 89976 +20
- Partials 1491 1492 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c81fd87
to
9f63c73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job.
Just a comment on the translation.
19207d2
to
15c66a2
Compare
15c66a2
to
ecaf055
Compare
5f5adee
to
88dbd3b
Compare
baa2905
to
a7a200a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: when I select a track, I can still edit it. I also left some comments :)
front/src/common/InfraSelector/InfraSelectorModalBodyStandard.tsx
Outdated
Show resolved
Hide resolved
8347753
to
b6d21af
Compare
5c2d84f
to
c481b6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested ✅
c481b6f
to
939bf90
Compare
closes #6077