Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: lock infra editor #6173

Merged
merged 1 commit into from
Jan 25, 2024
Merged

front: lock infra editor #6173

merged 1 commit into from
Jan 25, 2024

Conversation

Akctarus
Copy link
Contributor

closes #6077

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (a93fe8f) 27.90% compared to head (939bf90) 27.90%.

Files Patch % Lines
front/src/applications/editor/Editor.tsx 0.00% 14 Missing ⚠️
...cations/editor/tools/pointEdition/tool-factory.tsx 0.00% 8 Missing ⚠️
...s/InfraSelector/InfraSelectorModalBodyStandard.tsx 0.00% 6 Missing ⚠️
front/src/common/osrdContext.tsx 20.00% 4 Missing ⚠️
front/src/applications/editor/Home.tsx 0.00% 3 Missing ⚠️
front/src/reducers/editor/selectors.ts 0.00% 3 Missing ⚠️
...rc/applications/editor/tools/trackEdition/tool.tsx 0.00% 2 Missing ⚠️
...rc/applications/editor/tools/editorContextTypes.ts 0.00% 1 Missing ⚠️
front/src/reducers/infra/index.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6173      +/-   ##
============================================
- Coverage     27.90%   27.90%   -0.01%     
  Complexity     2165     2165              
============================================
  Files          1006     1006              
  Lines        126848   126877      +29     
  Branches       2581     2582       +1     
============================================
+ Hits          35401    35409       +8     
- Misses        89956    89976      +20     
- Partials       1491     1492       +1     
Flag Coverage Δ
core 78.58% <ø> (ø)
editoast 75.48% <ø> (+<0.01%) ⬆️
front 8.68% <16.00%> (+<0.01%) ⬆️
gateway 2.50% <ø> (ø)
railjson_generator 87.44% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/lock-infra-editor branch from c81fd87 to 9f63c73 Compare December 20, 2023 14:20
@Akctarus Akctarus marked this pull request as ready for review December 20, 2023 14:21
@Akctarus Akctarus requested a review from a team as a code owner December 20, 2023 14:21
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job.
Just a comment on the translation.

@Akctarus Akctarus force-pushed the tmn/lock-infra-editor branch 2 times, most recently from 19207d2 to 15c66a2 Compare December 22, 2023 15:41
@Akctarus Akctarus force-pushed the tmn/lock-infra-editor branch from 15c66a2 to ecaf055 Compare December 26, 2023 12:02
@Akctarus Akctarus force-pushed the tmn/lock-infra-editor branch from 5f5adee to 88dbd3b Compare January 3, 2024 10:08
@Akctarus Akctarus removed the request for review from SharglutDev January 3, 2024 10:09
@Akctarus Akctarus force-pushed the tmn/lock-infra-editor branch 8 times, most recently from baa2905 to a7a200a Compare January 5, 2024 16:11
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: when I select a track, I can still edit it. I also left some comments :)

@Akctarus Akctarus force-pushed the tmn/lock-infra-editor branch 2 times, most recently from 8347753 to b6d21af Compare January 12, 2024 13:31
@Akctarus Akctarus force-pushed the tmn/lock-infra-editor branch 3 times, most recently from 5c2d84f to c481b6f Compare January 25, 2024 11:25
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

@Akctarus Akctarus added this pull request to the merge queue Jan 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 25, 2024
@Akctarus Akctarus force-pushed the tmn/lock-infra-editor branch from c481b6f to 939bf90 Compare January 25, 2024 14:24
@Akctarus Akctarus enabled auto-merge January 25, 2024 14:24
@Akctarus Akctarus added this pull request to the merge queue Jan 25, 2024
Merged via the queue into dev with commit 8660de5 Jan 25, 2024
20 checks passed
@Akctarus Akctarus deleted the tmn/lock-infra-editor branch January 25, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lock infra editor tools when infra in locked
4 participants