-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: editor: add selection in search params #6175
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6175 +/- ##
============================================
+ Coverage 27.71% 27.91% +0.19%
Complexity 2165 2165
============================================
Files 1003 1006 +3
Lines 126630 126831 +201
Branches 2580 2581 +1
============================================
+ Hits 35093 35400 +307
+ Misses 90047 89940 -107
- Partials 1490 1491 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2bc41f8
to
8e5bbbd
Compare
8e5bbbd
to
6b411a8
Compare
d2daa51
to
5eeceee
Compare
96cd827
to
c888157
Compare
It works great with some elements in the selection, well done ! But we have an issue when have many (a lot) elements in the selection, the url is too long, and so if we refresh the page we have a 431 . I forgot that we have the 'square' selection tool ... and with it, it's easy to reproduce the issue, just select the Paris area with the tool. I don't know (for now) how to handle that. There is an other issue : if I do a selection, and then press the "back" button of my browser, the url changed but not the selection. There is 2 solutions for this issue : when we set the url with the new parameter, we should replace it in the history instead of doing a push. |
c888157
to
31c00c1
Compare
ceae927
to
7436942
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed all the files ✅
4f4cfbc
to
61d4f41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice PR ✅
close #5956