Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename editor "Search for alternative routes" button #6181

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Rename editor "Search for alternative routes" button #6181

merged 1 commit into from
Dec 21, 2023

Conversation

loic-hamelin
Copy link
Contributor

@loic-hamelin loic-hamelin requested a review from a team as a code owner December 21, 2023 13:23
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ea45fc5) 26.62% compared to head (289776a) 26.62%.

Files Patch % Lines
...ools/routeEdition/components/EditRouteMetadata.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #6181      +/-   ##
============================================
- Coverage     26.62%   26.62%   -0.01%     
  Complexity     2121     2121              
============================================
  Files           929      929              
  Lines        123373   123373              
  Branches       2677     2677              
============================================
- Hits          32852    32851       -1     
- Misses        88928    88929       +1     
  Partials       1593     1593
Flag Coverage Δ
core 78.83% <ø> (ø)
editoast 74.94% <ø> (-0.01%) ⬇️
front 9.36% <0.00%> (ø)
gateway 2.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster changed the title front: Rename "Search for alternative routes" button Rename editor "Search for alternative routes" button Dec 21, 2023
flomonster
flomonster approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flomonster flomonster enabled auto-merge December 21, 2023 13:52
Tguisnet
Tguisnet approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@Tguisnet Tguisnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR :) !

@flomonster flomonster added this pull request to the merge queue Dec 21, 2023
Merged via the queue into dev with commit 1fc2cd9 Dec 21, 2023
@flomonster flomonster deleted the loic-6124 branch December 21, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin approved these changes

@nicolaswurtz nicolaswurtz nicolaswurtz approved these changes

@flomonster flomonster flomonster approved these changes

@anisometropie anisometropie anisometropie approved these changes

@Tguisnet Tguisnet Tguisnet approved these changes

@axrolld axrolld axrolld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@loic-hamelin @woshilapin @nicolaswurtz @flomonster @anisometropie @Tguisnet @axrolld