Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: optimize mergeDistanceRangeMaps (use putMany) #6250

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

shenriotpro
Copy link
Contributor

@shenriotpro shenriotpro commented Jan 2, 2024

fixes #5843

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (687b5fc) 27.30% compared to head (d660a7f) 27.30%.

Files Patch % Lines
...main/kotlin/fr/sncf/osrd/utils/DistanceRangeMap.kt 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6250   +/-   ##
=========================================
  Coverage     27.30%   27.30%           
+ Complexity     2139     2136    -3     
=========================================
  Files           952      952           
  Lines        124899   124900    +1     
  Branches       2689     2690    +1     
=========================================
+ Hits          34105    34106    +1     
  Misses        89189    89189           
  Partials       1605     1605           
Flag Coverage Δ
core 78.88% <90.00%> (+<0.01%) ⬆️
editoast 75.36% <ø> (ø)
front 9.47% <ø> (ø)
gateway 2.54% <ø> (ø)
tests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shenriotpro shenriotpro marked this pull request as ready for review January 2, 2024 13:34
@shenriotpro shenriotpro requested a review from a team as a code owner January 2, 2024 13:34
@shenriotpro shenriotpro requested a review from Khoyo January 2, 2024 13:34
Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicky comments on the formatting, but other than that LGTM

@shenriotpro shenriotpro added this pull request to the merge queue Jan 2, 2024
Merged via the queue into dev with commit 84d57c2 Jan 2, 2024
@shenriotpro shenriotpro deleted the shenriot-opti-merge branch January 2, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: use optimized putMany to improve DistanceRangeMap performance
3 participants