Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: toggle 3d buildings #6260

Merged
merged 1 commit into from
Jan 4, 2024
Merged

front: toggle 3d buildings #6260

merged 1 commit into from
Jan 4, 2024

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Jan 3, 2024

closes #5872

@anisometropie anisometropie requested a review from a team as a code owner January 3, 2024 12:24
@anisometropie anisometropie force-pushed the vcs/3d-buildings branch 3 times, most recently from 0e8e117 to 24ac93c Compare January 3, 2024 16:07
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (3a3bc3f) 26.93% compared to head (fe289ca) 26.92%.
Report is 1 commits behind head on dev.

Files Patch % Lines
front/src/common/Map/Layers/OSM.tsx 0.00% 37 Missing ⚠️
...mon/Map/Settings/MapSettingsBackgroundSwitches.tsx 0.00% 17 Missing ⚠️
front/src/common/Map/WarpedMap/WarpedMap.tsx 0.00% 1 Missing ⚠️
front/src/reducers/map/index.ts 83.33% 0 Missing and 1 partial ⚠️
front/src/reducers/map/selectors.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6260      +/-   ##
============================================
- Coverage     26.93%   26.92%   -0.01%     
  Complexity     2136     2136              
============================================
  Files           961      961              
  Lines        124258   124310      +52     
  Branches       2574     2575       +1     
============================================
+ Hits          33472    33476       +4     
- Misses        89297    89344      +47     
- Partials       1489     1490       +1     
Flag Coverage Δ
core 78.88% <ø> (ø)
editoast 75.46% <ø> (-0.01%) ⬇️
front 8.69% <8.06%> (+<0.01%) ⬆️
gateway 2.54% <ø> (ø)
tests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and it works well ✅

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested :)

@anisometropie anisometropie added this pull request to the merge queue Jan 4, 2024
Merged via the queue into dev with commit b9c0352 Jan 4, 2024
@anisometropie anisometropie deleted the vcs/3d-buildings branch January 4, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: map: make it possible to hide 3D buildings in 2D view
4 participants