-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: remove relative imports #6269
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6269 +/- ##
============================================
- Coverage 27.68% 27.68% -0.01%
Complexity 2136 2136
============================================
Files 990 990
Lines 125794 125805 +11
Branches 2574 2574
============================================
- Hits 34830 34823 -7
- Misses 89475 89493 +18
Partials 1489 1489
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep the relative imports for the components importing other editor parts ?
Well spotted, I think I forgot some :) |
Some files still have a relative
I don't know if we have to use absolute path in open-api-config file too. (front/src/config/openapi-editoast-config.ts and front/src/config/openapi-gateway-config.ts) |
e50d7d4
to
6b59d52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done !
6b59d52
to
e0cfee5
Compare
closes #6027