Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: exclude deleted lines from base codecov value #6307

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

bougue-pe
Copy link
Contributor

@bougue-pe bougue-pe commented Jan 10, 2024

https://docs.codecov.com/docs/commit-status#removed_code_behavior

All components are concerned, open to debate:

  • improves (prevents) the case of "false alarm" when removing covered code.
  • degrades (hides) the case of legitimate alarm when covered code is replaced by uncovered code (new code must be covered as much as the untouched code).

@bougue-pe bougue-pe requested review from shenriotpro and a team and removed request for a team January 10, 2024 18:17
@bougue-pe bougue-pe requested a review from a team as a code owner January 10, 2024 18:17
@bougue-pe bougue-pe requested a review from eckter January 10, 2024 18:17
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a2b863) 27.66% compared to head (009f493) 27.66%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6307      +/-   ##
============================================
- Coverage     27.66%   27.66%   -0.01%     
  Complexity     2136     2136              
============================================
  Files           990      990              
  Lines        125877   125877              
  Branches       2575     2575              
============================================
- Hits          34825    34824       -1     
- Misses        89562    89563       +1     
  Partials       1490     1490              
Flag Coverage Δ
core 78.88% <ø> (ø)
editoast 75.57% <ø> (-0.01%) ⬇️
front 8.70% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.43% <ø> (ø)
tests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good idea to me.

Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My gut feeling is that we should be lenient on the "project" checks, but strict on the "patch" checks (i.e. I mostly want to check the added code is tested). Glad to hear other thoughts.

@bougue-pe bougue-pe added this pull request to the merge queue Jan 23, 2024
Merged via the queue into dev with commit 3650cc6 Jan 23, 2024
@bougue-pe bougue-pe deleted the peb/ci/codecov_ignore_rm_lines branch January 23, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants