-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenApi annotations for views::infra::routes endpoints #6338
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6338 +/- ##
============================================
+ Coverage 27.90% 27.91% +0.01%
Complexity 2165 2165
============================================
Files 1001 1001
Lines 126473 126489 +16
Branches 2580 2580
============================================
+ Hits 35296 35314 +18
+ Misses 89688 89686 -2
Partials 1489 1489
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it and found a bug. We have a 404
missing field infra_id
on the endpoint /infra/8/routes/Detector/detecto.XXXXX/
75a7b81
to
2959d74
Compare
Oops, thanks good catch 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to wait for the fix of this #6317 to be able to test the changes (will probably cause some conflicts)
2959d74
to
cb92b84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Reviewed + Tested)
- /infra/{infra_id}/routes/{waypoint_type}/{waypoint_id}/ - /infra/{infra_id}/routes/track_ranges/ Also includes a discriminator elimination fix.
cb92b84
to
c41873b
Compare
refs #4580 #3625