Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: rolling stock model v2 #6381

Merged
merged 1 commit into from
Mar 7, 2024
Merged

editoast: rolling stock model v2 #6381

merged 1 commit into from
Mar 7, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Jan 18, 2024 •
edited
Loading

close #6323

@Wadjetz Wadjetz self-assigned this Jan 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.35826% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 28.26%. Comparing base (1f27b88) to head (177abd7).
Report is 1 commits behind head on dev.

Files Patch % Lines
editoast/src/modelsv2/rolling_stock_model.rs 76.23% 24 Missing ⚠️
editoast/src/views/train_schedule/mod.rs 0.00% 15 Missing ⚠️
editoast/src/views/rolling_stocks/mod.rs 92.42% 5 Missing ⚠️
editoast/src/views/timetable/import.rs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                dev    #6381   +/-   ##
=========================================
  Coverage     28.26%   28.26%           
  Complexity     2179     2179           
=========================================
  Files          1049     1051    +2     
  Lines        130290   130332   +42     
  Branches       2578     2578           
=========================================
+ Hits          36824    36837   +13     
- Misses        91977    92006   +29     
  Partials       1489     1489
Flag Coverage Δ
core 79.44% <ø> (ø)
editoast 75.08% <85.26%> (-0.08%) ⬇️
front 8.62% <100.00%> (+<0.01%) ⬆️
gateway 2.50% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz force-pushed the ebe/editoast-rolling-stock-model-v2 branch 5 times, most recently from 78c9edc to 8654c65 Compare January 25, 2024 09:13
@Wadjetz Wadjetz force-pushed the ebe/editoast-rolling-stock-model-v2 branch 4 times, most recently from d34f9d5 to 79f8e57 Compare January 26, 2024 14:57
@Wadjetz Wadjetz added the area:editoast Work on Editoast Service label Jan 26, 2024
@Wadjetz Wadjetz force-pushed the ebe/editoast-rolling-stock-model-v2 branch from 79f8e57 to dd5bc0e Compare January 26, 2024 15:04
@Wadjetz Wadjetz marked this pull request as ready for review January 26, 2024 15:05
@Wadjetz Wadjetz requested a review from a team as a code owner January 26, 2024 15:05
@Wadjetz Wadjetz force-pushed the ebe/editoast-rolling-stock-model-v2 branch from dd5bc0e to e338f33 Compare January 26, 2024 15:16
leovalais
leovalais requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Here's a bunch of suggestions (don't hesitate to call me if something is unclear or if you need some help :))

@flomonster flomonster removed their request for review January 31, 2024 17:17
@Wadjetz Wadjetz force-pushed the ebe/editoast-rolling-stock-model-v2 branch 9 times, most recently from 9088b3c to 6c5bc4c Compare February 2, 2024 14:23
@Wadjetz Wadjetz force-pushed the ebe/editoast-rolling-stock-model-v2 branch 4 times, most recently from d86b022 to 55afdad Compare February 13, 2024 13:54
@Wadjetz Wadjetz requested a review from Tguisnet February 14, 2024 08:50
@Wadjetz Wadjetz force-pushed the ebe/editoast-rolling-stock-model-v2 branch 9 times, most recently from 9ac314a to 6df033d Compare February 22, 2024 08:53
@Wadjetz Wadjetz force-pushed the ebe/editoast-rolling-stock-model-v2 branch 2 times, most recently from fe02412 to 438c8ec Compare March 4, 2024 14:24
@Wadjetz Wadjetz requested a review from leovalais March 4, 2024 14:44
@Wadjetz Wadjetz force-pushed the ebe/editoast-rolling-stock-model-v2 branch from 438c8ec to ee61478 Compare March 5, 2024 13:42
leovalais
leovalais approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hamz2a
hamz2a approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@hamz2a hamz2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Wadjetz Wadjetz requested a review from SharglutDev March 7, 2024 08:53
@Wadjetz Wadjetz force-pushed the ebe/editoast-rolling-stock-model-v2 branch from ee61478 to 04f12de Compare March 7, 2024 09:03
@flomonster flomonster mentioned this pull request Mar 7, 2024
Merged
@Wadjetz Wadjetz force-pushed the ebe/editoast-rolling-stock-model-v2 branch from 04f12de to 177abd7 Compare March 7, 2024 09:14
@Wadjetz Wadjetz added this pull request to the merge queue Mar 7, 2024
Merged via the queue into dev with commit 6dbaf9f Mar 7, 2024
22 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast-rolling-stock-model-v2 branch March 7, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovalais leovalais leovalais approved these changes

@hamz2a hamz2a hamz2a approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

@Tguisnet Tguisnet Awaiting requested review from Tguisnet

Assignees

@Wadjetz Wadjetz

Labels
area:editoast Work on Editoast Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move RollingStockModel to model V2
4 participants
@Wadjetz @leovalais @hamz2a @SharglutDev