-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide a undefined/null speed limit when user provide empty field #6428
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6428 +/- ##
============================================
- Coverage 27.71% 22.73% -4.98%
============================================
Files 1003 694 -309
Lines 126630 115343 -11287
Branches 2580 808 -1772
============================================
- Hits 35093 26223 -8870
+ Misses 90047 88316 -1731
+ Partials 1490 804 -686
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM
front/src/applications/editor/tools/rangeEdition/speedSection/SpeedSectionMetadataForm.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works 🎉.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4acb6a6
to
4c0a4f4
Compare
fix the first problem of this issue
The problem was that the way we converted the values entered in Speed limit field returned 0 when the field was left empty.
How to test ?