Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: handle weird electrification values in rs editor #6445

Merged
merged 1 commit into from
Jan 29, 2024
Merged

editoast: handle weird electrification values in rs editor #6445

merged 1 commit into from
Jan 29, 2024

Conversation

louisgreiner
Copy link
Contributor

Closes #5957

@louisgreiner louisgreiner requested a review from a team as a code owner January 25, 2024 10:16
@louisgreiner
Copy link
Contributor Author

Tested with these cases :

@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37aac79) 27.72% compared to head (d812d86) 27.88%.
Report is 22 commits behind head on dev.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #6445      +/-   ##
============================================
+ Coverage     27.72%   27.88%   +0.15%     
  Complexity     2165     2165              
============================================
  Files          1003     1007       +4     
  Lines        126611   126926     +315     
  Branches       2580     2582       +2     
============================================
+ Hits          35099    35389     +290     
- Misses        90022    90045      +23     
- Partials       1490     1492       +2
Flag Coverage Δ
core 78.58% <ø> (ø)
editoast 75.47% <100.00%> (-0.02%) ⬇️
front 8.65% <ø> (+0.28%) ⬆️
gateway 2.50% <ø> (ø)
railjson_generator 87.44% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais requested a review from Tristramg January 25, 2024 12:05
@louisgreiner louisgreiner force-pushed the lgr/electrification-values-in-rs-editor branch 4 times, most recently from 23bf155 to c8fe0c4 Compare January 26, 2024 09:27
flomonster
flomonster requested changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
Some minor changes to apply and we're good to merge it 🎉

@louisgreiner louisgreiner force-pushed the lgr/electrification-values-in-rs-editor branch 4 times, most recently from 76cfb48 to 2177cf4 Compare January 26, 2024 13:48
flomonster
flomonster approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louisgreiner louisgreiner force-pushed the lgr/electrification-values-in-rs-editor branch from 2177cf4 to d812d86 Compare January 26, 2024 14:13
bougue-pe
bougue-pe approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No migration means a new dump generation is necessary to deliver bug fix (which is fine by me).

@louisgreiner louisgreiner added this pull request to the merge queue Jan 29, 2024
Merged via the queue into dev with commit 76e4337 Jan 29, 2024
21 checks passed
@louisgreiner louisgreiner deleted the lgr/electrification-values-in-rs-editor branch January 29, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster approved these changes

@bougue-pe bougue-pe bougue-pe approved these changes

@Tguisnet Tguisnet Awaiting requested review from Tguisnet

@Tristramg Tristramg Awaiting requested review from Tristramg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird electrification values in RS editor
3 participants
@louisgreiner @flomonster @bougue-pe