Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix core MRSP #6480

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Fix core MRSP #6480

merged 1 commit into from
Jan 26, 2024

Conversation

flomonster
Copy link
Contributor

fix #6468

@flomonster flomonster requested a review from a team as a code owner January 26, 2024 16:05
@flomonster flomonster requested a review from multun January 26, 2024 16:05
@flomonster flomonster force-pushed the fam/fix-mrsp-construction branch from 9406301 to f305d87 Compare January 26, 2024 16:05
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f53b7f5) 27.87% compared to head (69e8115) 27.87%.

Files Patch % Lines
.../osrd/infra/api/tracks/undirected/SpeedLimits.java 50.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6480      +/-   ##
============================================
- Coverage     27.87%   27.87%   -0.01%     
- Complexity     2165     2167       +2     
============================================
  Files          1007     1007              
  Lines        126912   126918       +6     
  Branches       2582     2585       +3     
============================================
- Hits          35379    35377       -2     
- Misses        90041    90046       +5     
- Partials       1492     1495       +3     
Flag Coverage Δ
core 78.56% <50.00%> (-0.03%) ⬇️
editoast 75.45% <ø> (-0.02%) ⬇️
front 8.65% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.44% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@flomonster flomonster force-pushed the fam/fix-mrsp-construction branch from f305d87 to 69e8115 Compare January 26, 2024 16:24
@flomonster flomonster enabled auto-merge January 26, 2024 16:28
@flomonster flomonster added this pull request to the merge queue Jan 26, 2024
Merged via the queue into dev with commit 061e45f Jan 26, 2024
21 checks passed
@flomonster flomonster deleted the fam/fix-mrsp-construction branch January 26, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect MRSP computation with composition code
3 participants