Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: osrd-schemas: fix rolling stock effort curve validator #6517

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Morgane-SJK
Copy link
Contributor

No description provided.

@Morgane-SJK Morgane-SJK requested a review from a team as a code owner January 30, 2024 18:43
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b2c010) 28.05% compared to head (bb7e8ee) 28.05%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6517      +/-   ##
============================================
- Coverage     28.05%   28.05%   -0.01%     
  Complexity     2167     2167              
============================================
  Files          1015     1015              
  Lines        127448   127448              
  Branches       2584     2584              
============================================
- Hits          35757    35754       -3     
- Misses        90197    90200       +3     
  Partials       1494     1494              
Flag Coverage Δ
core 78.56% <ø> (ø)
editoast 75.43% <ø> (-0.02%) ⬇️
front 8.63% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.44% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Morgane-SJK Morgane-SJK force-pushed the mso/fix-rolling-stock-schema-json branch from 23487c4 to bb7e8ee Compare January 30, 2024 18:59
@Morgane-SJK Morgane-SJK changed the title osrd-schemas: fix effort curve validator editoast: osrd-schemas: fix rolling stock effort curve validator Jan 30, 2024
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Morgane-SJK Morgane-SJK added this pull request to the merge queue Jan 30, 2024
Merged via the queue into dev with commit 74c1276 Jan 30, 2024
21 checks passed
@Morgane-SJK Morgane-SJK deleted the mso/fix-rolling-stock-schema-json branch January 30, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants