core: fix gauge loading from railjson #6524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bougue-pe
force-pushed
the
peb/core/fix_gauge_load
branch
2 times, most recently
from
3f91584 to
50e9c14
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6524 +/- ##
============================================
- Coverage 28.00% 28.00% -0.01%
Complexity 2167 2167
============================================
Files 1034 1034
Lines 127675 127683 +8
Branches 2603 2602 -1
============================================
- Hits 35759 35758 -1
- Misses 90403 90411 +8
- Partials 1513 1514 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bougue-pe
force-pushed
the
peb/core/fix_gauge_load
branch
from
50e9c14 to
b64bd25
Compare
eckter
approved these changes
Feb 1, 2024
Erashin
approved these changes
Feb 1, 2024
Add corresponding tests: adapt existing tests to read railjson instead of modifying gauge constraints after read (add gauge in railjson generator). Also: * remove useless code in RawInfraAdapter.kt
bougue-pe
force-pushed
the
peb/core/fix_gauge_load
branch
from
b64bd25 to
302e1e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add corresponding tests: adapt existing tests to read railjson instead of modifying gauge constraints after read (add gauge in railjson generator).
⚠️ this will add gauge constraints to
TA0in small_infra.Also: