Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add search filters in timetable #6549

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

RomainValls
Copy link
Contributor

@RomainValls RomainValls commented Feb 1, 2024

closes #6385

@RomainValls RomainValls requested a review from a team as a code owner February 1, 2024 15:22
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 228 lines in your changes are missing coverage. Please review.

Comparison is base (41f5bcc) 27.79% compared to head (d128675) 27.75%.
Report is 1 commits behind head on dev.

Files Patch % Lines
...s/trainschedule/components/Timetable/Timetable.tsx 0.00% 228 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6549      +/-   ##
============================================
- Coverage     27.79%   27.75%   -0.05%     
  Complexity     2172     2172              
============================================
  Files          1041     1041              
  Lines        128088   128285     +197     
  Branches       2569     2569              
============================================
- Hits          35608    35603       -5     
- Misses        90995    91197     +202     
  Partials       1485     1485              
Flag Coverage Δ
core 79.36% <ø> (ø)
editoast 75.20% <ø> (-0.03%) ⬇️
front 8.33% <0.00%> (-0.02%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomainValls RomainValls force-pushed the rvs/front-add-search-elements-to-train-in-timetable branch from d67ffff to a246f44 Compare February 7, 2024 13:55
@RomainValls RomainValls changed the title front: render unique tags for composition codes in timetable front: add search filters in timetable Feb 12, 2024
@RomainValls RomainValls force-pushed the rvs/front-add-search-elements-to-train-in-timetable branch from 5595ac8 to 09edfdd Compare February 13, 2024 13:13
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR ! Left some comments :)

@nicolaswurtz nicolaswurtz self-assigned this Feb 15, 2024
@RomainValls RomainValls self-assigned this Feb 16, 2024
@RomainValls RomainValls force-pushed the rvs/front-add-search-elements-to-train-in-timetable branch 3 times, most recently from 6560cdc to 03ae09f Compare February 16, 2024 14:38
@nicolaswurtz nicolaswurtz removed the request for review from Yohh February 16, 2024 14:42
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 💪

@RomainValls RomainValls force-pushed the rvs/front-add-search-elements-to-train-in-timetable branch from 03ae09f to d128675 Compare February 16, 2024 14:48
@nicolaswurtz nicolaswurtz added this pull request to the merge queue Feb 16, 2024
Merged via the queue into dev with commit d1f7533 Feb 16, 2024
22 checks passed
@nicolaswurtz nicolaswurtz deleted the rvs/front-add-search-elements-to-train-in-timetable branch February 16, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagination support for Train Schedule
3 participants