Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: Add signaling systems support in the rolling stock editor #6552

Merged
merged 1 commit into from
Feb 19, 2024
Merged

front: Add signaling systems support in the rolling stock editor #6552

merged 1 commit into from
Feb 19, 2024

Conversation

SarahBellaha
Copy link
Contributor

Closes #6356

@SarahBellaha SarahBellaha force-pushed the vcs/new-field-rolling-stock-editor-tvm branch 3 times, most recently from 2309148 to a1bccb1 Compare February 5, 2024 09:39
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2024 •
edited
Loading

Codecov Report

Attention: 358 lines in your changes are missing coverage. Please review.

Comparison is base (b597500) 27.79% compared to head (93230bd) 27.73%.
Report is 5 commits behind head on dev.

Files Patch % Lines
...llingStockEditor/RollingStockEditorFormHelpers.tsx 9.90% 191 Missing ⚠️
...onents/RollingStockCard/RollingStockCardDetail.tsx 1.00% 99 Missing ⚠️
.../hooks/useCompleteRollingStockSchemasProperties.ts 43.33% 17 Missing ⚠️
front/src/modules/rollingStock/helpers/utils.ts 50.00% 16 Missing ⚠️
front/src/modules/rollingStock/types.ts 0.00% 11 Missing ⚠️
front/src/common/api/enhancedEditoastApi.ts 0.00% 7 Missing ⚠️
...ents/RollingStockEditor/RollingStockEditorForm.tsx 22.22% 7 Missing ⚠️
front/src/utils/array.ts 40.00% 6 Missing ⚠️
front/src/common/BootstrapSNCF/InputSNCF.tsx 25.00% 3 Missing ⚠️
...tock/components/RollingStockSelector/sampleData.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #6552      +/-   ##
============================================
- Coverage     27.79%   27.73%   -0.06%     
  Complexity     2172     2172              
============================================
  Files          1041     1042       +1     
  Lines        128088   128461     +373     
  Branches       2569     2569              
============================================
+ Hits          35606    35633      +27     
- Misses        90997    91343     +346     
  Partials       1485     1485
Flag Coverage Δ
core 79.36% <ø> (ø)
editoast 75.20% <ø> (-0.02%) ⬇️
front 8.35% <16.35%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBellaha SarahBellaha force-pushed the vcs/new-field-rolling-stock-editor-tvm branch 2 times, most recently from ba419e1 to 6573838 Compare February 5, 2024 10:45
@SarahBellaha SarahBellaha marked this pull request as ready for review February 5, 2024 12:48
@SarahBellaha SarahBellaha requested review from a team as code owners February 5, 2024 12:48
flomonster
flomonster requested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

I reviewed the PR #6377 after it was merged.
We assume a static list of signaling systems in the schema defining the SignalingSystem enum. To be consistent with the application we should consider signaling systems as dynamic data.

Some editoast changes should be made (in another PR).

@flomonster flomonster changed the title front: add supported_signaling_systems field in rolling stock editor for tvm Add signaling systems support in the rolling stock editor Feb 6, 2024
@anisometropie anisometropie force-pushed the vcs/new-field-rolling-stock-editor-tvm branch from 6573838 to c5ba72a Compare February 6, 2024 15:56
@anisometropie anisometropie changed the title Add signaling systems support in the rolling stock editor front: Add signaling systems support in the rolling stock editor Feb 7, 2024
@SarahBellaha SarahBellaha force-pushed the vcs/new-field-rolling-stock-editor-tvm branch 4 times, most recently from 7242c63 to 894d1ef Compare February 8, 2024 15:13
@anisometropie anisometropie force-pushed the vcs/new-field-rolling-stock-editor-tvm branch from 894d1ef to 3e7755a Compare February 12, 2024 10:04
@SarahBellaha SarahBellaha force-pushed the vcs/new-field-rolling-stock-editor-tvm branch 2 times, most recently from 94e8a51 to 1aca311 Compare February 13, 2024 10:34
nicolaswurtz
nicolaswurtz suggested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@nicolaswurtz nicolaswurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Hi! Thx for this work ;)

  • missing translation/title
  • missing alphabetic order of checkbox

clarani
clarani requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, great job 👏 Some remarks:

  • use the new hook to get the rollingStock schema (and remove it from the props)
  • simplify RollingStockEditorOnboardSystemEquipmentForm: only 1 component, don't try to make it generic as we don't need it for the moment

Thanks :)

@SarahBellaha SarahBellaha force-pushed the vcs/new-field-rolling-stock-editor-tvm branch 2 times, most recently from 11246cf to 7201ccc Compare February 15, 2024 11:24
clarani
clarani reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, thanks for the work 🚀

@SarahBellaha SarahBellaha force-pushed the vcs/new-field-rolling-stock-editor-tvm branch from 7201ccc to 5d87ad0 Compare February 15, 2024 16:54
clarani
clarani reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 1 typo and LGTM, you can already rebase and squash your commits ✅

@SarahBellaha SarahBellaha force-pushed the vcs/new-field-rolling-stock-editor-tvm branch 2 times, most recently from 4543a0f to 4b9dd34 Compare February 16, 2024 09:02
clarani
clarani approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested ✅

anisometropie
anisometropie reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to use rollingStockSchemasProperties everywhere rather than RS_SCHEMA_PROPERTIES, it’s more confusing than anything to have two version in circulation and to wonder which one to use where.

@anisometropie anisometropie force-pushed the vcs/new-field-rolling-stock-editor-tvm branch from 4b9dd34 to ba3170d Compare February 19, 2024 09:47
@SarahBellaha SarahBellaha force-pushed the vcs/new-field-rolling-stock-editor-tvm branch from ba3170d to 93230bd Compare February 19, 2024 10:03
flomonster
flomonster approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SharglutDev SharglutDev added this pull request to the merge queue Feb 19, 2024
Merged via the queue into dev with commit 33eb9dc Feb 19, 2024
22 checks passed
@SharglutDev SharglutDev deleted the vcs/new-field-rolling-stock-editor-tvm branch February 19, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anisometropie anisometropie anisometropie left review comments

@nicolaswurtz nicolaswurtz nicolaswurtz approved these changes

@flomonster flomonster flomonster approved these changes

@clarani clarani clarani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new field in rolling stock editor to select supported signalling systems (TVM) + adapt payload
6 participants
@SarahBellaha @nicolaswurtz @flomonster @anisometropie @clarani @SharglutDev