ci: make the commit title check more permissive #6557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
multun
commented
Feb 2, 2024
•
multun
commented
- allow underscores in module names
- use a title character blacklist instead of a whitelist
- forbid non-ascii characters
flomonster
reviewed
Feb 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6557 +/- ##
=============================================
+ Coverage 28.01% 71.41% +43.39%
=============================================
Files 1032 189 -843
Lines 127748 24994 -102754
Branches 2603 0 -2603
=============================================
- Hits 35792 17850 -17942
+ Misses 90441 7144 -83297
+ Partials 1515 0 -1515
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Feb 2, 2024
multun
force-pushed
the
permissive-commit-name
branch
2 times, most recently
from
f0fa6d7 to
915110a
Compare
- allow underscores in module names - use a title character blacklist instead of a whitelist - forbid non-ascii characters
multun
force-pushed
the
permissive-commit-name
branch
from
915110a to
f3e317f
Compare
flomonster
approved these changes
Feb 5, 2024
bougue-pe
approved these changes
Feb 5, 2024
bougue-pe
added a commit
to OpenRailAssociation/osrd-website
that referenced
this pull request
Feb 5, 2024
also port last check of commit after OpenRailAssociation/osrd#6557
bougue-pe
added a commit
to OpenRailAssociation/osrd-website
that referenced
this pull request
Feb 5, 2024
also port last check of commit after OpenRailAssociation/osrd#6557
bougue-pe
added a commit
to OpenRailAssociation/osrd-website
that referenced
this pull request
Feb 8, 2024
also port last check of commit after OpenRailAssociation/osrd#6557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.