Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: clean architecture of infra editor folder #6571

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 5, 2024

closes #6560

@clarani clarani requested a review from a team as a code owner February 5, 2024 11:00
@clarani clarani force-pushed the cni-6560-clean-editor-architecture branch from 38f9f47 to f26c865 Compare February 5, 2024 11:01
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 913 lines in your changes are missing coverage. Please review.

Comparison is base (a362aa6) 28.00% compared to head (5853212) 27.90%.
Report is 3 commits behind head on dev.

Files Patch % Lines
...rc/applications/editor/tools/rangeEdition/types.ts 0.00% 65 Missing and 1 partial ⚠️
front/src/applications/editor/consts.ts 0.00% 57 Missing and 1 partial ⚠️
...rc/applications/editor/tools/pointEdition/types.ts 0.00% 54 Missing ⚠️
...c/applications/editor/tools/switchEdition/types.ts 0.00% 45 Missing ⚠️
...rc/applications/editor/tools/trackEdition/utils.ts 32.69% 35 Missing ⚠️
front/src/applications/editor/Editor.tsx 0.00% 32 Missing and 1 partial ⚠️
...rc/applications/editor/tools/routeEdition/types.ts 0.00% 29 Missing and 1 partial ⚠️
...rc/applications/editor/tools/trackEdition/types.ts 0.00% 27 Missing and 1 partial ⚠️
front/src/applications/editor/tools/utils.ts 0.00% 28 Missing ⚠️
front/src/applications/editor/tools/constsTools.ts 0.00% 25 Missing and 1 partial ⚠️
... and 94 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6571      +/-   ##
============================================
- Coverage     28.00%   27.90%   -0.11%     
  Complexity     2170     2170              
============================================
  Files          1036     1039       +3     
  Lines        127912   127855      -57     
  Branches       2606     2617      +11     
============================================
- Hits          35822    35675     -147     
- Misses        90572    90652      +80     
- Partials       1518     1528      +10     
Flag Coverage Δ
core 78.53% <ø> (ø)
editoast 75.34% <ø> (+0.04%) ⬆️
front 8.41% <9.24%> (-0.20%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni-6560-clean-editor-architecture branch 3 times, most recently from a664e30 to 0d9143f Compare February 7, 2024 14:33
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

- move EditorState to reducer/editor
- remove editor/nav.ts file (not used anymore)
- create consts and types files when needed
- reorganize files
- remove relative imports
- rename type LayerType into Layer
- move style files to /styles
- rename TOOL_TYPES into TOOL_NAMES and move it to constTools
- move types/editor to applications/editor
@clarani clarani force-pushed the cni-6560-clean-editor-architecture branch from 0d9143f to 5853212 Compare February 8, 2024 11:08
@clarani clarani enabled auto-merge February 8, 2024 11:08
@clarani clarani added this pull request to the merge queue Feb 8, 2024
Merged via the queue into dev with commit 6b9dca7 Feb 8, 2024
22 checks passed
@clarani clarani deleted the cni-6560-clean-editor-architecture branch February 8, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: reorganise editor's files and architecture
3 participants