Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route-dependant speed sections #6599

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Conversation

leovalais
Copy link
Contributor

@leovalais leovalais commented Feb 8, 2024

closes #6519

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (906da79) 27.79% compared to head (389509f) 27.78%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6599      +/-   ##
============================================
- Coverage     27.79%   27.78%   -0.01%     
  Complexity     2172     2172              
============================================
  Files          1043     1043              
  Lines        128732   128735       +3     
  Branches       2570     2570              
============================================
- Hits          35777    35775       -2     
- Misses        91469    91474       +5     
  Partials       1486     1486              
Flag Coverage Δ
core 79.36% <100.00%> (+<0.01%) ⬆️
editoast 75.31% <ø> (-0.03%) ⬇️
front 8.34% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.26% <100.00%> (+<0.01%) ⬆️
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais force-pushed the lva/conditional-speed-sections branch 4 times, most recently from 11696fe to 568741c Compare February 9, 2024 17:30
@leovalais leovalais marked this pull request as ready for review February 9, 2024 17:30
@leovalais leovalais requested review from a team as code owners February 9, 2024 17:30
@leovalais leovalais requested a review from Erashin February 9, 2024 17:30
@leovalais leovalais changed the title WIP Add route-dependant speed sections Add route-dependant speed sections Feb 9, 2024
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for tests/

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Review and tested. The speed section edition seems to work properly.

Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leovalais leovalais added this pull request to the merge queue Feb 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2024
@leovalais leovalais force-pushed the lva/conditional-speed-sections branch from 568741c to 389509f Compare February 21, 2024 11:25
@leovalais leovalais enabled auto-merge February 21, 2024 11:27
@leovalais leovalais added this pull request to the merge queue Feb 21, 2024
Merged via the queue into dev with commit 3db23ac Feb 21, 2024
22 checks passed
@leovalais leovalais deleted the lva/conditional-speed-sections branch February 21, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed section by routes implement new schema
4 participants