Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: editor: add direction, remove angles, for PSL Signs #6603

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

nicolaswurtz
Copy link
Contributor

Closes #6600

  • Angles are not geo/sch anymore.
  • Angles are not needed anymore in points editions.
  • Direction is needed in PSL Sign card

@nicolaswurtz nicolaswurtz requested a review from a team as a code owner February 9, 2024 08:30
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (6b9dca7) 27.92% compared to head (7780205) 27.89%.
Report is 1 commits behind head on dev.

Files Patch % Lines
...or/tools/rangeEdition/speedSection/PslSignCard.tsx 0.00% 11 Missing ⚠️
...tools/rangeEdition/speedSection/EditPSLSection.tsx 0.00% 2 Missing ⚠️
.../rangeEdition/components/RangeEditionLeftPanel.tsx 0.00% 1 Missing ⚠️
...rc/applications/editor/tools/rangeEdition/types.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6603      +/-   ##
============================================
- Coverage     27.92%   27.89%   -0.03%     
+ Complexity     2179     2177       -2     
============================================
  Files          1040     1040              
  Lines        127871   127614     -257     
  Branches       2619     2610       -9     
============================================
- Hits          35703    35599     -104     
+ Misses        90641    90484     -157     
- Partials       1527     1531       +4     
Flag Coverage Δ
core 79.37% <ø> (+0.77%) ⬆️
editoast 75.35% <ø> (-0.01%) ⬇️
front 8.41% <0.00%> (+<0.01%) ⬆️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolaswurtz nicolaswurtz force-pushed the nwz/add-direction-remove-angle-psl-sign-editor branch from 0530e41 to d97d7a1 Compare February 9, 2024 08:33
@nicolaswurtz nicolaswurtz changed the title front: editor: Add direction, remove angles, for PSL Signs front: editor: add direction, remove angles, for PSL Signs Feb 9, 2024
@nicolaswurtz nicolaswurtz force-pushed the nwz/add-direction-remove-angle-psl-sign-editor branch 2 times, most recently from 1259f91 to 1c361bd Compare February 9, 2024 09:08
@nicolaswurtz nicolaswurtz force-pushed the nwz/add-direction-remove-angle-psl-sign-editor branch from 6ca5bb8 to 7780205 Compare February 9, 2024 10:03
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clarani clarani added this pull request to the merge queue Feb 9, 2024
Merged via the queue into dev with commit 645b57f Feb 9, 2024
22 checks passed
@clarani clarani deleted the nwz/add-direction-remove-angle-psl-sign-editor branch February 9, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PSL edition fails because of usage of deprecated angle fields
3 participants