Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests rolling stocks examples #6604

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Fix tests rolling stocks examples #6604

merged 1 commit into from
Feb 9, 2024

Conversation

flomonster
Copy link
Contributor

No description provided.

@flomonster flomonster requested a review from a team as a code owner February 9, 2024 09:03
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b9dca7) 27.92% compared to head (950a785) 27.93%.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6604   +/-   ##
=========================================
  Coverage     27.92%   27.93%           
  Complexity     2179     2179           
=========================================
  Files          1040     1040           
  Lines        127871   127896   +25     
  Branches       2619     2619           
=========================================
+ Hits          35703    35722   +19     
- Misses        90641    90647    +6     
  Partials       1527     1527           
Flag Coverage Δ
core 78.60% <ø> (ø)
editoast 75.36% <ø> (+<0.01%) ⬆️
front 8.41% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is this needed for anything specific?

@flomonster
Copy link
Contributor Author

This field was never used and has recently been removed from the schema.

@flomonster flomonster added this pull request to the merge queue Feb 9, 2024
Merged via the queue into dev with commit 2700a72 Feb 9, 2024
22 checks passed
@flomonster flomonster deleted the fam/fix-rs-examples branch February 9, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants