-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix edition of effort curve #6614
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6614 +/- ##
============================================
- Coverage 27.88% 27.88% -0.01%
Complexity 2175 2175
============================================
Files 1044 1044
Lines 127897 127910 +13
Branches 2605 2605
============================================
- Hits 35666 35663 -3
- Misses 90712 90728 +16
Partials 1519 1519
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR and good job to spot this sneaky bug, everything works great now ! Lgtm :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested ✅
front/src/modules/rollingStock/components/RollingStockEditor/RollingStockEditorCurves.tsx
Outdated
Show resolved
Hide resolved
1adabbb
to
033703e
Compare
close #6579