Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix edition of effort curve #6614

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

kmer2016
Copy link
Contributor

@kmer2016 kmer2016 commented Feb 12, 2024

close #6579

@kmer2016 kmer2016 requested a review from a team as a code owner February 12, 2024 14:53
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (4105b19) 27.88% compared to head (033703e) 27.88%.
Report is 1 commits behind head on dev.

Files Patch % Lines
...ts/RollingStockEditor/RollingStockEditorCurves.tsx 0.00% 48 Missing ⚠️
...components/RollingStockEditor/CurveSpreadsheet.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6614      +/-   ##
============================================
- Coverage     27.88%   27.88%   -0.01%     
  Complexity     2175     2175              
============================================
  Files          1044     1044              
  Lines        127897   127910      +13     
  Branches       2605     2605              
============================================
- Hits          35666    35663       -3     
- Misses        90712    90728      +16     
  Partials       1519     1519              
Flag Coverage Δ
core 79.36% <ø> (ø)
editoast 75.20% <ø> (-0.02%) ⬇️
front 8.42% <2.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmer2016 kmer2016 requested review from SarahBellaha and removed request for Akctarus February 12, 2024 14:56
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR and good job to spot this sneaky bug, everything works great now ! Lgtm :)

Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

@kmer2016 kmer2016 force-pushed the cnh-fix-unable-to-edit-effort-curve branch from 1adabbb to 033703e Compare February 13, 2024 14:05
@kmer2016 kmer2016 added this pull request to the merge queue Feb 13, 2024
Merged via the queue into dev with commit cfb3409 Feb 13, 2024
22 checks passed
@kmer2016 kmer2016 deleted the cnh-fix-unable-to-edit-effort-curve branch February 13, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to edit speed effort curve
4 participants