Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix bug lpv color when selecting a speed section tag #6622

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 13, 2024

closes #5287

I fixed the color of the PSL when you select a speedLimitTag, but found a new bug (backend #6623): if you select a speedLimitTag and the PSL does not have it, the PSL disappear but not its signs !

Here with a correct speedLimitTag:
image

@clarani clarani requested a review from a team as a code owner February 13, 2024 10:37
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (630fdc7) 27.89% compared to head (d3241b0) 17.60%.
Report is 2 commits behind head on dev.

Files Patch % Lines
front/src/common/Map/Layers/GeoJSONs.tsx 0.00% 3 Missing ⚠️
front/src/common/Map/Layers/SpeedLimits.tsx 0.00% 2 Missing ⚠️
...ront/src/common/Map/Layers/extensions/SNCF/PSL.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #6622       +/-   ##
=============================================
- Coverage     27.89%   17.60%   -10.29%     
  Complexity     2175     2175               
=============================================
  Files          1042      890      -152     
  Lines        127870   105065    -22805     
  Branches       2601     2605        +4     
=============================================
- Hits          35667    18496    -17171     
+ Misses        90684    85050     -5634     
  Partials       1519     1519               
Flag Coverage Δ
core 79.36% <ø> (-0.26%) ⬇️
editoast ?
front 8.42% <0.00%> (+<0.01%) ⬆️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clarani clarani added this pull request to the merge queue Feb 14, 2024
Merged via the queue into dev with commit 3acd113 Feb 14, 2024
22 checks passed
@clarani clarani deleted the cni-5287-fix-lpv-colors branch February 14, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: LPV are displayed without color
2 participants