Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the minimum zoom level for detectors at 8 #6630

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix the minimum zoom level for detectors at 8 #6630

merged 1 commit into from
Feb 14, 2024

Conversation

Caracol3
Copy link
Contributor

@Caracol3 Caracol3 commented Feb 13, 2024 •
edited
Loading

  • add minzoom 8 in detectors.tsx

close #6066

@Caracol3
front: map: detectors display at zoom level 8
3ad882a 
- add minzoom 8 in detectors.tsx
@Caracol3 Caracol3 added kind:enhancement Improvement of existing features area:front Work on Standard OSRD Interface modules labels Feb 13, 2024
@Caracol3 Caracol3 requested a review from a team as a code owner February 13, 2024 14:46
@codecov Codecov
Copy link

codecov bot commented Feb 13, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0ace615) 27.88% compared to head (3ad882a) 27.88%.
Report is 4 commits behind head on dev.

Files Patch % Lines
front/src/common/Map/Layers/Detectors.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #6630      +/-   ##
============================================
- Coverage     27.88%   27.88%   -0.01%     
  Complexity     2175     2175              
============================================
  Files          1044     1044              
  Lines        127888   127911      +23     
  Branches       2605     2605              
============================================
+ Hits          35665    35667       +2     
- Misses        90704    90725      +21     
  Partials       1519     1519
Flag Coverage Δ
core 79.36% <ø> (ø)
editoast 75.22% <ø> (-0.03%) ⬇️
front 8.42% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster changed the title front: map: detectors display at zoom level 8 Fix the minimum zoom level for detectors at 8 Feb 13, 2024
flomonster
flomonster approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (tested + reviewed)

@nicolaswurtz nicolaswurtz added this pull request to the merge queue Feb 14, 2024
Merged via the queue into dev with commit 218b6fb Feb 14, 2024
22 checks passed
@nicolaswurtz nicolaswurtz deleted the mcy/front-changing-zoom-level-on-detectors-in-the-map branch February 14, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaswurtz nicolaswurtz nicolaswurtz approved these changes

@flomonster flomonster flomonster approved these changes

@SharglutDev SharglutDev Awaiting requested review from SharglutDev

@Omar-938 Omar-938 Awaiting requested review from Omar-938

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detectors are displayed regardless of zoom level
3 participants
@Caracol3 @nicolaswurtz @flomonster