Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix curves visibility reset when add data in spreadsheet #6631

Merged

Conversation

kmer2016
Copy link
Contributor

closes #6588

@kmer2016 kmer2016 requested a review from a team as a code owner February 13, 2024 15:29
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (cfb3409) 27.88% compared to head (bc09f26) 27.87%.
Report is 2 commits behind head on dev.

Files Patch % Lines
...ules/rollingStock/components/RollingStockCurve.tsx 0.00% 32 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6631      +/-   ##
============================================
- Coverage     27.88%   27.87%   -0.02%     
+ Complexity     2175     2171       -4     
============================================
  Files          1044     1044              
  Lines        127910   127908       -2     
  Branches       2605     2601       -4     
============================================
- Hits          35669    35650      -19     
- Misses        90722    90740      +18     
+ Partials       1519     1518       -1     
Flag Coverage Δ
core 79.35% <ø> (-0.02%) ⬇️
editoast 75.19% <ø> (-0.04%) ⬇️
front 8.42% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmer2016 kmer2016 force-pushed the cnh-fix-reset-of-filtered-curve-when-edit-spreasheet branch from 94f2160 to bc09f26 Compare February 13, 2024 15:44
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :)

@SharglutDev SharglutDev added this pull request to the merge queue Feb 15, 2024
Merged via the queue into dev with commit 3ad757b Feb 15, 2024
22 checks passed
@SharglutDev SharglutDev deleted the cnh-fix-reset-of-filtered-curve-when-edit-spreasheet branch February 15, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating a curve spreadsheet is reseting displayed curves
3 participants