Adding an error inventory to editoast #6632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6632 +/- ##
============================================
+ Coverage 27.74% 27.79% +0.05%
Complexity 2172 2172
============================================
Files 1042 1043 +1
Lines 128465 128710 +245
Branches 2569 2570 +1
============================================
+ Hits 35640 35773 +133
- Misses 91340 91451 +111
- Partials 1485 1486 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sim51
force-pushed
the
bsi/error-messages
branch
6 times, most recently
from
c676413 to
42a7338
Compare
sim51
force-pushed
the
bsi/error-messages
branch
2 times, most recently
from
3294c2a to
26f7be8
Compare
sim51
force-pushed
the
bsi/error-messages
branch
from
26f7be8 to
4d4f1f4
Compare
flomonster
requested changes
Feb 16, 2024
This was referenced Feb 16, 2024
sim51
force-pushed
the
bsi/error-messages
branch
from
4d4f1f4 to
65890a3
Compare
flomonster
approved these changes
Feb 19, 2024
SharglutDev
requested changes
Feb 19, 2024
sim51
force-pushed
the
bsi/error-messages
branch
from
65890a3 to
0fd8ad3
Compare
ElysaSrc
approved these changes
Feb 19, 2024
sim51
force-pushed
the
bsi/error-messages
branch
5 times, most recently
from
cd74fb3 to
885a1d6
Compare
SharglutDev
requested changes
Feb 19, 2024
sim51
force-pushed
the
bsi/error-messages
branch
2 times, most recently
from
f317a18 to
f2657ee
Compare
flomonster
changed the title
sim51
force-pushed
the
bsi/error-messages
branch
10 times, most recently
from
61b370c to
7f6d9fa
Compare
flomonster
reviewed
Feb 20, 2024
sim51
force-pushed
the
bsi/error-messages
branch
from
7f6d9fa to
3d32d79
Compare
SharglutDev
approved these changes
Feb 20, 2024
- editoast generates API errors definition into openapi.yaml by looking at all object that derives from 'EditoastError' - frontend task "script:i18n-api-errors" reads the openapi.yml and i18n errors.json file to check if there are some missing or invalid values - frontend task is run on the CI, within the check of the openapi
sim51
force-pushed
the
bsi/error-messages
branch
from
3d32d79 to
a6b59f6
Compare
|
For memory, I opened this ticket #6685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/osrd-project/osrd-confidential/issues/281 for more details
close #6193
What I did is :
openapi.yamlby looking at all object that derives fromEditoastErroropenapi.ymland i18nerrors.jsonfile to check if there are some missing or invalid valuescheck_editoast_openapi)Moreover, the function
extractMessageFromErrorinfront/src/utils/error.tshas been changed, to search the message to display in the I18N.