front: editor: improves speed sections form #6646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6646 +/- ##
============================================
- Coverage 27.79% 27.77% -0.02%
Complexity 2172 2172
============================================
Files 1043 1043
Lines 128738 128751 +13
Branches 2570 2570
============================================
- Hits 35779 35766 -13
- Misses 91473 91499 +26
Partials 1486 1486
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SharglutDev
reviewed
Feb 15, 2024
front/src/applications/editor/tools/rangeEdition/speedSection/SpeedSectionMetadataForm.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/editor/tools/rangeEdition/speedSection/SpeedSectionMetadataForm.tsx
Outdated
Show resolved
Hide resolved
Fixes #6442. Details: - "Add new limit" button is no more disabled - Save button is disabled instead when speed limits are not valid - Speed limits by tags in the form are now handled as an array, separated from the collection in entity.properties.speed_limit_by_tag - Uses "required" and "pattern" attributes to get a red border when tag or speed inputs are not valid
SharglutDev
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6442.
Details: