-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix small infra stations characteristics #6661
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6661 +/- ##
============================================
- Coverage 27.79% 27.75% -0.05%
Complexity 2172 2172
============================================
Files 1041 1041
Lines 128120 128285 +165
Branches 2569 2569
============================================
- Hits 35609 35601 -8
- Misses 91026 91199 +173
Partials 1485 1485
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b7b0e40
to
d95d75a
Compare
419065d
to
401d45c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. You need to generate railjson examples though.
7754914
to
7e000ef
Compare
7e000ef
to
67df788
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! Thanks for the PR
The commit name is a bit vague tho, but it's good enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect thanks a lot 🙏
Closes #4375
-> to apply changes, run
./scripts/load-railjson-infra.sh small_infra tests/data/infras/small_infra/infra.json
or load the updated dump from sharepoint