Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix small infra stations characteristics #6661

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

louisgreiner
Copy link
Contributor

@louisgreiner louisgreiner commented Feb 16, 2024

Closes #4375

  • fix South West Station and West Station inversion
  • replace station ch : "aa" -> "BV"
  • make trigrams unique

-> to apply changes, run ./scripts/load-railjson-infra.sh small_infra tests/data/infras/small_infra/infra.json or load the updated dump from sharepoint

@louisgreiner louisgreiner requested a review from a team as a code owner February 16, 2024 10:46
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffd07be) 27.79% compared to head (67df788) 27.75%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6661      +/-   ##
============================================
- Coverage     27.79%   27.75%   -0.05%     
  Complexity     2172     2172              
============================================
  Files          1041     1041              
  Lines        128120   128285     +165     
  Branches       2569     2569              
============================================
- Hits          35609    35601       -8     
- Misses        91026    91199     +173     
  Partials       1485     1485              
Flag Coverage Δ
core 79.36% <ø> (ø)
editoast 75.19% <ø> (-0.04%) ⬇️
front 8.33% <ø> (-0.02%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louisgreiner louisgreiner force-pushed the lgr/fix-small-infra branch 2 times, most recently from b7b0e40 to d95d75a Compare February 16, 2024 16:08
@louisgreiner louisgreiner requested a review from a team as a code owner February 16, 2024 16:08
@louisgreiner louisgreiner requested a review from multun February 16, 2024 16:08
@louisgreiner louisgreiner force-pushed the lgr/fix-small-infra branch 3 times, most recently from 419065d to 401d45c Compare February 19, 2024 08:46
@louisgreiner louisgreiner requested a review from a team as a code owner February 19, 2024 08:46
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You need to generate railjson examples though.

@louisgreiner louisgreiner force-pushed the lgr/fix-small-infra branch 2 times, most recently from 7754914 to 7e000ef Compare February 19, 2024 09:28
@louisgreiner louisgreiner self-assigned this Feb 19, 2024
Copy link
Contributor

@Castavo Castavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Thanks for the PR

The commit name is a bit vague tho, but it's good enough

@louisgreiner louisgreiner changed the title tests: fix small infra tests: fix small infra stations characteristics Feb 19, 2024
@louisgreiner louisgreiner requested review from Khoyo and removed request for multun February 20, 2024 08:25
Copy link
Contributor

@bloussou bloussou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks a lot 🙏

@louisgreiner louisgreiner added this pull request to the merge queue Feb 20, 2024
Merged via the queue into dev with commit 461fc91 Feb 20, 2024
22 checks passed
@louisgreiner louisgreiner deleted the lgr/fix-small-infra branch February 20, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incoherent names in small infra
5 participants