editoast: enhance editoast error context #6662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6662 +/- ##
============================================
- Coverage 27.82% 27.82% -0.01%
Complexity 2172 2172
============================================
Files 1043 1043
Lines 128807 128849 +42
Branches 2570 2570
============================================
+ Hits 35841 35851 +10
- Misses 91480 91512 +32
Partials 1486 1486
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sim51
force-pushed
the
bsi/error-messages-editoast
branch
5 times, most recently
from
e81d274 to
843c033
Compare
flomonster
approved these changes
Feb 21, 2024
nicolaswurtz
approved these changes
Feb 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
- context should be an object with parameter to be well displayed in the UI - adding needed parameters in some errors (like InfraNotFound for example)
sim51
force-pushed
the
bsi/error-messages-editoast
branch
from
843c033 to
ae057e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/osrd-project/osrd-confidential/issues/281#issuecomment-1948412084 for more details.
This PR contains :
InfraNotFoundfor example)